Skip to content

Commit

Permalink
코드 최적화
Browse files Browse the repository at this point in the history
  • Loading branch information
@bjrambo
bjrambo committed Jul 12, 2014
1 parent c3d7efa commit 7b01e8c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
4 changes: 2 additions & 2 deletions modules/attendance/attendance.controller.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function init()
function procAttendanceInsertAttendance()
{
$today = zDate(date('YmdHis'),"Ymd");
//if($_SESSION['is_attended'] == $today) return new Object(-1,'attend_already_checked');
if($_SESSION['is_attended'] == $today) return new Object(-1,'attend_already_checked');

/*attendance model 객체 생성*/
$oAttendanceModel = getModel('attendance');
Expand Down Expand Up @@ -84,7 +84,7 @@ function procAttendanceDeleteData()
$daily_info = $oAttendanceModel->getUserAttendanceData($member_info->member_srl, $obj->check_day);

//삭제시 출책여부를 하지않았다고 인식시켜 스킨용 표기 방법 찾게 (2013.12.11 by BJRambo)
//$_SESSION['is_attended'] = '0';
$_SESSION['is_attended'] = '0';

if($oAttendanceModel->getIsCheckedA($obj->member_srl, $obj->check_day)!=0)
{
Expand Down
13 changes: 5 additions & 8 deletions modules/attendance/attendance.model.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function insertAttendance($about_position, $greetings, $member_srl=null)
$year_month = zDate(date('YmdHis'),"Ym");
$yesterday = zDate(date("YmdHis",strtotime("-1 day")),"Ymd");

//if($_SESSION['is_attended'] == $today) return new Object(-1,'attend_already_checked');
if($_SESSION['is_attended'] == $today) return new Object(-1,'attend_already_checked');

$oModuleModel = getModel('module');
$config = $oModuleModel->getModuleConfig('attendance');
Expand Down Expand Up @@ -300,13 +300,10 @@ function insertAttendance($about_position, $greetings, $member_srl=null)

if($config->continuity_monthly == 'yes')
{
for($i=1;$i<=12;$i++)
if($continuity->data % 30 === 0)

This comment has been minimized.

Sign in to view

Copy link
@bjrambo

bjrambo Jul 12, 2014

Author Owner

@bnu 으흠.. 이렇게 코드를 짰는데, 제가 기억이흐릿한 상태에서 코딩을 진행해서 기억이 안나더군요 ㅠ.ㅠ.

혹시 이 코드가 맞는지 확인 부탁드리겠습니다 ~ :)

This comment has been minimized.

Sign in to view

Copy link
@bjrambo

bjrambo Jul 14, 2014

Author Owner

@bnu
오잉! 코드가 저렇게 하면 더 짧아지겠네요
저는 단순히

if($config->continuity_monthly == 'yes')
{
    if($continuity->data % 30 === 0)
    {
        $obj->perfect_m = 'Y';
    }
    $continuity->data++;
}
else
{
    $continuity->data++;
}

요론식으로 길게 늘어지게 만들수밖에 없겠구나 했는데 :)
좋은 꿀팁 감사합니다
乃 👍
{
if($continuity->data==(30*$i))
{
$obj->perfect_m = 'Y';
break;
}
$obj->perfect_m = 'Y';
break;
}
$continuity->data++;
}
Expand Down Expand Up @@ -534,7 +531,7 @@ function insertAttendance($about_position, $greetings, $member_srl=null)
}
}

//$_SESSION['is_attended'] = $today;
$_SESSION['is_attended'] = $today;

/*포인트 추가*/
if($obj->today_point != 0 && $logged_info->member_srl)
Expand Down

0 comments on commit 7b01e8c

Please sign in to comment.