Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooltip works only the first time #264

Closed
gioboa opened this issue Apr 3, 2023 · 5 comments
Closed

tooltip works only the first time #264

gioboa opened this issue Apr 3, 2023 · 5 comments
Assignees
Labels
COMMUNITY: good first issue Good for newcomers TYPE: bug Something isn't working

Comments

@gioboa
Copy link
Contributor

gioboa commented Apr 3, 2023

Here is a video for this issue.
The tooltip works only the first time
https://www.loom.com/share/66f693d2804b4e3d92ef3770cac1c39e

@gioboa gioboa added TYPE: bug Something isn't working COMMUNITY: good first issue Good for newcomers labels Apr 3, 2023
@pranit-yawalkar
Copy link
Contributor

pranit-yawalkar commented Apr 4, 2023

Hey, anyone working on this, if not then I would like to take this.

@gioboa
Copy link
Contributor Author

gioboa commented Apr 4, 2023

Sure, you can take it. Thanks

@jansedlon
Copy link

jansedlon commented Apr 5, 2023

A looked at the code and the proposed solution could be to rename the onAnimationEnd$ to onTransitionEnd$ and in the showTooltip function could be like this

if (stateSignal.value === "hidden") {
  stateSignal.value = "unpositioned";
}

However it seems like there a event leak somewhere. Not sure if in the code or the Qwik itself, but the more times the tooltip is shown, the more times the onMouseLeave$ and onMouseEnter$ events are called

@gioboa
Copy link
Contributor Author

gioboa commented Apr 5, 2023

Thanks, you solved the problem, but the first tooltip position seems wrong.
Can you check it please?

Screenshot 2023-04-05 at 11 12 06

@pranit-yawalkar
Copy link
Contributor

I have pushed the changes, can you please review them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: good first issue Good for newcomers TYPE: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants