Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class-variance-authority is not installed by the CLI #698

Open
Balastrong opened this issue Apr 8, 2024 · 4 comments
Open

class-variance-authority is not installed by the CLI #698

Balastrong opened this issue Apr 8, 2024 · 4 comments
Labels
STATUS-2: team is working on this Scheduled for work by the core team

Comments

@Balastrong
Copy link
Contributor

As Is

Not a blocker but maybe it's worth mentioning, on a fresh project after installing qwik-ui and the button component, I noticed class-variance-authority was not installed.

Repro Steps

  1. Create a new qwik project
  2. Install qwik-ui pnpm dlx qwik-ui init
  3. Install the button component pnpm qwik-ui add button

To Be

Since the button component has an import from class-variance-authority I was expecting the cli to automatically add it on package.json, either on the lib install or when adding a component (e.g. button) that uses it.

@LazyClicks
Copy link

+1

@shairez
Copy link
Contributor

shairez commented May 29, 2024

thanks @Balastrong !

@maiieul did you add it as a dependency to the styled component? or should it be installed separately?

@maiieul
Copy link
Contributor

maiieul commented May 31, 2024

@shairez It should be installed with the cli. Do we simply need to add it to dependencies on the styled kit?

@brandiqa
Copy link

I would also like to add that @qwikest/icons and tailwindcss-animate are also not installed as well.

@shairez shairez added the STATUS-2: team is working on this Scheduled for work by the core team label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-2: team is working on this Scheduled for work by the core team
Projects
Status: Backlog
Development

No branches or pull requests

5 participants