Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悶] Combobox value should clear search on value selection #816

Open
Toeler opened this issue Jun 1, 2024 · 0 comments
Open

[馃悶] Combobox value should clear search on value selection #816

Toeler opened this issue Jun 1, 2024 · 0 comments
Assignees
Labels
P2: minor If it's a bug, it doesn't make Qwik unstable but doesn't have workarounds either PKG: headless Related to the headless kit STATUS-2: team is working on this Scheduled for work by the core team TYPE: bug Something isn't working

Comments

@Toeler
Copy link

Toeler commented Jun 1, 2024

Which package is affected?

Headless Kit

Describe the bug

When selecting a value in a combobox, the search is kept (despite not being visible). This results in the list maintaining the filter when it is next opened.

Reproduction

https://stackblitz.com/edit/qwik-starter-ketzj8?file=src%2Froutes%2Findex.tsx

Steps to reproduce

On a page with a Combobox control:

  • Click into the input box
  • Type a letter to filter the options (e.g. "a")
  • Click on any of the options
  • Click on the trigger to open the combobox

Expected:

  • The full list to be visible
  • The combobox input area shows the current value
  • Typing in the combobox should start a new search

Actual:

  • The previous search is still in the internal state
  • The combobox input area shows the current value
  • Typing in the combobox appends the current value (so the user actually has to clear the input)

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @builder.io/qwik: ^1.4.3 => 1.5.5 
    @builder.io/qwik-city: ^1.4.3 => 1.4.3 
    @qwik-ui/headless: ^0.4.2 => 0.4.2 
    typescript: 5.3.3 => 5.3.3 
    undici: 5.28.2 => 5.28.2 
    vite: 4.5.2 => 4.5.2

Additional Information

Notes:

  • There is also a similar issue when using the defaultLabel property or otherwise trying to pre-select a value, it also configures the search and so the first time the dropdown is opened it is pre-filtered to only that value.
@Toeler Toeler added STATUS-1: needs triage This doesn't seem right TYPE: bug Something isn't working labels Jun 1, 2024
@maiieul maiieul added PKG: headless Related to the headless kit STATUS-2: team is working on this Scheduled for work by the core team P1: nice to have / fix Not an urgent enhancement or bug (has workarounds) P3: important If Bug - it makes Qwik UI unstable but doesn't affect the majority of users P2: minor If it's a bug, it doesn't make Qwik unstable but doesn't have workarounds either and removed STATUS-1: needs triage This doesn't seem right P3: important If Bug - it makes Qwik UI unstable but doesn't affect the majority of users P1: nice to have / fix Not an urgent enhancement or bug (has workarounds) labels Jun 1, 2024
@maiieul maiieul changed the title [馃悶] Combox value should clear search on value selection [馃悶] Combobox value should clear search on value selection Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: minor If it's a bug, it doesn't make Qwik unstable but doesn't have workarounds either PKG: headless Related to the headless kit STATUS-2: team is working on this Scheduled for work by the core team TYPE: bug Something isn't working
Projects
Status: Upcoming
Development

No branches or pull requests

3 participants