Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX supported or bash in particular? #5

Closed
jasonkarns opened this issue May 12, 2016 · 2 comments
Closed

POSIX supported or bash in particular? #5

jasonkarns opened this issue May 12, 2016 · 2 comments

Comments

@jasonkarns
Copy link
Collaborator

I run shellcheck on all my shell code (or rather, it's run automatically via syntastic, hence how I noticed some of the issues).

Quite a few of the errors/warnings that it is reporting are POSIX compliance issues. Shellcheck only does posix compliance if the shebang is sh. So is sh-semver intended to be POSIX compliant? If so, I'll submit some PRs with the posix warnings resolved. If not, I recommend we change the shebang to bash.

@jasonkarns
Copy link
Collaborator Author

I've resolved every shellcheck error and warning except: all the usages of local and the array-like behavior of semver_sort.

My personal vote is to switch the shebang to bash which would make all the local actually mean something. And would give us true array capability.

@qzb qzb closed this as completed in 195f122 May 12, 2016
@qzb
Copy link
Owner

qzb commented May 12, 2016

I didn't know this tool, it works great, thanks. Initially it was intended to be POSIX compliant, but I don't think it is a good idea anymore. As you suggested, I've changed shebang to bash. If you want to make a pull request fixing rest of issues, it will be appreciated.

@qzb qzb reopened this May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants