Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial width vs boundWidth #325

Closed
tresf opened this issue May 8, 2018 · 2 comments
Closed

Serial width vs boundWidth #325

tresf opened this issue May 8, 2018 · 2 comments
Assignees
Labels

Comments

@tresf
Copy link
Contributor

tresf commented May 8, 2018

@bberenz is this a typo? I think this should be width instead of boundWidth.

if (!serialProps.isNull("width")) {
try { boundWidth = serialProps.getInt("boundWidth"); }
catch(JSONException e) { log.warn("Cannot read {} as a value for bound width, defaulting to begin/end values", serialProps.opt("width")); }
}

@tresf tresf added the bug label May 8, 2018
@akberenz
Copy link
Member

akberenz commented May 9, 2018

Yeah, almost looks like it got changed in a refactor of the variable name without noticing. Fixed under 50023b1

@ryanomite
Copy link

Thank you both! Works great on our end, now.

@tresf tresf closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants