Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message tweaking #118

Closed
hadley opened this issue Jan 10, 2019 · 4 comments
Closed

Error message tweaking #118

hadley opened this issue Jan 10, 2019 · 4 comments

Comments

@hadley
Copy link
Member

hadley commented Jan 10, 2019

Currently:

Error in result_create(conn@ptr, statement, is_statement) : 
  You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'BOOLEAN) AS `y`
FROM `dbplyr_eqginqmosw`
LIMIT 11' at line 1 [1064]

So needs C++ equivalent of call. = FALSE or C++ in _RMariaDB_result_create

Would also be worthwhile checking why there is leading space before "You have"

@krlmlr
Copy link
Member

krlmlr commented Jan 16, 2019

@romainfrancois Do you remember, off the top of your head, the call. = FALSE equivalent in Rcpp?

@romainfrancois
Copy link

romainfrancois commented Jan 16, 2019

The easiest is to use -DRCPP_DEFAULT_INCLUDE_CALL=false in the Makevars

@romainfrancois
Copy link

See https://github.com/tidyverse/dplyr/blob/master/src/Makevars#L2

This makes all Rcpp exceptions not include the call. See RcppCore/Rcpp#868 for the back story.

@krlmlr krlmlr closed this as completed in bce7024 Jan 26, 2019
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants