Added Vertica data types #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good thanks! Can you add a bullet to NEWS.md with the change and |
|
@jimhester Done. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took PostgreSQL types to start, and used more common type names. Reference: https://my.vertica.com/docs/7.2.x/HTML/index.htm#Authoring/SQLReferenceManual/DataTypes/SQLDataTypes.htm
Also, since vertica doesn't care about the order of rows unless specifically asked, I've added a parameter to
test_roundtripto be able to enforce the same row order before the comparison. The roundtrip succeeds withforce_sorted=TRUE.