Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate matchHistogram from eemont #29

Merged
merged 2 commits into from Dec 20, 2021
Merged

Migrate matchHistogram from eemont #29

merged 2 commits into from Dec 20, 2021

Conversation

aazuspan
Copy link
Collaborator

Hi @csaybar and @davemlz, here's the first eemont feature migrated over!

  • Implement part of Moving matchHistogram and panSharpen from eemont to ee_extra #28 by adding the ee_extra.Spectral.matchHistogram function
  • Fix a bug in the original matchHistogram implementation that caused band order and image bounds to change on matched images
  • Make bands arg optional to simplify matching bands within collections

@aazuspan aazuspan added the enhancement New feature or request label Dec 18, 2021
@aazuspan
Copy link
Collaborator Author

Tests are failing because they can't find the EE_TOKEN env var, but that's set and working in my fork. Seems like the workflow isn't able to access my fork secrets...

@davemlz davemlz merged commit 992f64f into r-earthengine:master Dec 20, 2021
@davemlz
Copy link
Collaborator

davemlz commented Dec 20, 2021

Merged! Thank you @aazuspan!

@aazuspan aazuspan mentioned this pull request Feb 27, 2022
Merged
@aazuspan aazuspan deleted the histogram branch March 9, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aazuspan @davemlz