Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use a sql file to sql key of 'Data' parameter (entity sheet) #115

Open
abennici opened this issue Feb 9, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@abennici
Copy link
Collaborator

abennici commented Feb 9, 2021

We have only possibility to write sql query chain for this key but not have the capacity to join a sql file including this query. For long and complexe query chain, this alternative method could be more easily for user.

@abennici abennici added the enhancement New feature or request label Feb 9, 2021
@eblondel
Copy link
Collaborator

eblondel commented Feb 9, 2021

Can you clarify if you refer to the source or the upload? For source we can already have a SQL file as source file, geoflow detects SQL type and tries to execute the query to read the data source. For upload, we only have a "sql" property (that we need to think in renaming.. ) are you referring to this, and supporting a reference a SQL script file for upload?

@eblondel eblondel added the question Further information is requested label Feb 9, 2021
@abennici
Copy link
Collaborator Author

abennici commented Feb 9, 2021

My request refer to the upload call "sql". The sql property (or renaming) could by update to support the two type of declaration under ?

e.g. sql: SELECT * FROM mydata_
or
e.g. sql: myUploadRequest@http://mysql.sql

@eblondel
Copy link
Collaborator

eblondel commented Feb 9, 2021

For that we already have uploadSource, but we don't think we manage Sql files here (at least not yet). by analogy we should have uploadSourceSql as renaming of sql. It would make sense to have management of SQL files for uploadSource, as content of the sql can be large, and doesn't help readability of Data column

@eblondel eblondel removed the question Further information is requested label Feb 9, 2021
@eblondel eblondel added this to the 1.0.0 milestone Dec 7, 2021
@eblondel eblondel removed this from the 1.0.0 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants