Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-portable flags used for compilation #264

Closed
samuel-rosa opened this issue Apr 29, 2019 · 7 comments

Comments

@samuel-rosa
Copy link

commented Apr 29, 2019

I get the following on Ubuntu Linux 16.04 LTS, R-release, GCC:

* checking compilation flags used ... WARNING
Compilation used the following non-portable flag(s):
  ‘-Wdate-time’ ‘-Werror=format-security’ ‘-Wformat’

See the full build log at https://builder.r-hub.io/status/spsann_2.2.0.tar.gz-268f9200dc964f988a305582ce2bf429

I know that this can be solved locally by setting alternative flags in the ~/.R/Makevars file. How can I solve this issue when using rhub?

@akashrajkn

This comment has been minimized.

Copy link

commented Apr 30, 2019

I have the same issue as well.

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented May 9, 2019

The Ubuntu build of R has those flags, by default, I think. So unless you specified these flags yourself, and/or you are seeing them for other platforms that CRAN uses, e.g. R-devel on Debian, you can ignore them.

@gaborcsardi gaborcsardi closed this May 9, 2019

@gaborcsardi gaborcsardi added this to Done in 2019 May May 9, 2019

@rikardn

This comment has been minimized.

Copy link

commented May 15, 2019

First: sorry for posting to a closed issue.

These flags are set in the /etc/R/Makeconf in Ubuntu, but strangely not in Debian. Do you think I should file an issue to Ubuntu or could you consider fixing this for the rhub Ubuntu machine? (I am having the same issue on my machine with Ubuntu 18.10) Perhaps we can save others from scratching their heads on this WARNING.

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented May 15, 2019

We could "fix" this in the Dockerfile, but I am just not sure if that's the right thing to do. This is a builder that is for Ubuntu, so I guess you would want to keep the default Ubuntu settings?

The maintainer knows about this, btw.: https://stat.ethz.ch/pipermail/r-package-devel/2019q2/003898.html

@rikardn

This comment has been minimized.

Copy link

commented May 15, 2019

You are right, it makes sense to leave it as it is in the Dockerfile. Also because it might be fixed in future Ubuntu versions. Thanks for the informative link!

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Actually, this is not so much a bug in Ubuntu, but a bug in the R check code. Yes, these flags are not portable, but they are not coming from the package, they are coming from the system setup, so in this case it does not actually matter if they are portable or not.

@gaborcsardi

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I'll report it as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.