Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora using V8 package #540

Open
ijlyttle opened this issue Oct 14, 2022 · 2 comments
Open

Fedora using V8 package #540

ijlyttle opened this issue Oct 14, 2022 · 2 comments

Comments

@ijlyttle
Copy link

ijlyttle commented Oct 14, 2022

I don't know if this is an r-hub issue or a V8 issue; I'll start here.

I am prepping the vegawidget package for another CRAN release. According to CRAN, there are no problems on Fedora for vegawidget (0.4.1.) All the checks are passing using GitHub Actions, and on the other rhub::check_for_cran() default platforms.

However, using rhub's "fedora-gcc-devel", I get a V8-related problem for both the existing CRAN version of vegawidget (0.4.1), and the dev version (proposed for CRAN):

 >   svg <- vw_to_svg(vegawidget(spec_mtcars))
 Error in context_eval(join(src), private$context, serialize, await) : 
   SyntaxError: Use of const in strict mode.
 Calls: vw_to_svg ... <Anonymous> -> evaluate_js -> get_str_output -> context_eval
 Execution halted

Links to vegawidget runs on r-hub "fedora-gcc-devel": CRAN and dev.

I understand that curating the versions of libv8 for all these platforms is an ongoing challenge, so I hope @jeroen won't mind that I cc him, here.

There is no great urgency to this. I'd like to make a CRAN release at some point, but there are no deadlines.

Of course, I remain grateful for all that r-hub does to support development efforts, and all that @jeroen does to keep V8 up and running. Thanks as always!

@gaborcsardi
Copy link
Collaborator

We need to update the Fedora container to make V8 work. It won't work with the current container, unfortunately.

@ijlyttle
Copy link
Author

Hi @gaborcsardi - thanks!

Given that it's working at CRAN and that V8 is a known issue here, the path is clear for me to resume submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants