Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment for methods in clones of non-portable objects #215

Merged
merged 5 commits into from Oct 20, 2020
Merged

Fix environment for methods in clones of non-portable objects #215

merged 5 commits into from Oct 20, 2020

Conversation

wch
Copy link
Member

@wch wch commented Oct 19, 2020

Fixes #214.

@wch wch requested a review from gaborcsardi as a code owner October 19, 2020 15:18
@wch wch mentioned this pull request Oct 19, 2020
Closed
gaborcsardi
gaborcsardi approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the internals of the non-portable classes any more. :( I guess having good test cases are enough to make sure this is good.

@wch wch merged commit c884b14 into master Oct 20, 2020
@wch wch deleted the fix-clone-inherit branch October 20, 2020 00:40
@wch
Copy link
Member Author

wch commented Oct 20, 2020

The structure of the objects with inheritance gets surprisingly complicated, and I'm glad that there are a lot of tests.

This was referenced Oct 27, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inherited methods in clone of non-portable object have incorrect environment
2 participants
@wch @gaborcsardi