Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the default version of Rtools for R 4.2 be "42"? #553

Closed
yutannihilation opened this issue Apr 23, 2022 · 5 comments
Closed

Shouldn't the default version of Rtools for R 4.2 be "42"? #553

yutannihilation opened this issue Apr 23, 2022 · 5 comments

Comments

@yutannihilation
Copy link
Contributor

Sorry if I'm misunderstanding the code, but I guess currently "40" is chosen no matter the version is above or below R 4.2.

core.getInput("rtools-version") || (version.charAt(0) == "3" ? "35" : "40");

@yutannihilation yutannihilation added the bug an unexpected problem or unintended behavior label Apr 23, 2022
@gaborcsardi
Copy link
Member

We'll see if GitHub will switch to 4.2 on the VMs.

@gaborcsardi gaborcsardi removed the bug an unexpected problem or unintended behavior label Apr 23, 2022
@yutannihilation
Copy link
Contributor Author

I think release already point to R 4.2 except for the Ubuntu runners, but it acquires Rtools40 (right?), which doesn't feel correct to me. In my understanding, it's unrelated to whether the GitHub switches to 4.2 or not. Am I wrong...?

@gaborcsardi
Copy link
Member

R 4.2 works fine with Rtools40, which is pre-installed on on the VM. Installing rtools 4.2 would take several minutes and it does not have any effect for most people. You can already select rtools 4.2 if you want to install it.

If GitHub switches to Rtools 4.2 on the VM, then we'll of course use that, installing Rtools40 would not make much sense then.

@yutannihilation
Copy link
Contributor Author

Thanks. I really need Rtools42, not Rtools40, for testing the things where the subtle differences do matter, but I agree it's a rare case and I can keep specifying rtools-version: '42'. Closing now. Sorry for the noise.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants