Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong context for error handling? #246

Closed
dmurdoch opened this issue Feb 11, 2023 · 1 comment
Closed

Wrong context for error handling? #246

dmurdoch opened this issue Feb 11, 2023 · 1 comment

Comments

@dmurdoch
Copy link

This pkgdown issue r-lib/pkgdown#2278 appears to have been caused by the code in callr:::make_vanilla_script_expr being evaluated in the wrong context: there's a call in that function to flush(stderr()), and it was calling the stderr() that was defined in the R Markdown document, not the base function.

The function callr:::make_vanilla_script_expr is very complicated, so I can't tell whether this is a bug in it, or a misuse in pkgdown, but for sure defining a function named stderr in a document should not cause the document build to fail.

@dmurdoch
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant