Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting a naive-time with %Z or %z should result in a warning or error #204

Closed
DavisVaughan opened this issue Apr 7, 2021 · 0 comments · Fixed by #211
Closed

Formatting a naive-time with %Z or %z should result in a warning or error #204

DavisVaughan opened this issue Apr 7, 2021 · 0 comments · Fixed by #211
Labels
feature a feature request or enhancement

Comments

@DavisVaughan
Copy link
Member

All results will be NA, so maybe an error?

library(clock)
x <- as_naive_time(year_month_day(2019, 1, 1))
format(x, format = "%Z")
#> [1] NA

Created on 2021-04-06 by the reprex package (v1.0.0)
@DavisVaughan DavisVaughan changed the title Formatting a naive-time with %Z should result in a warning or error Formatting a naive-time with %Z or %z should result in a warning or error Apr 7, 2021
@DavisVaughan DavisVaughan added bug an unexpected problem or unintended behavior feature a feature request or enhancement and removed bug an unexpected problem or unintended behavior labels Apr 7, 2021
@DavisVaughan DavisVaughan mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate warnings when formatting naive-times with %Z or %z r-lib/clock
1 participant
@DavisVaughan