Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rlang 1.0.0 snapshots #285

Merged
merged 3 commits into from Jan 31, 2022
Merged

Update to rlang 1.0.0 snapshots #285

merged 3 commits into from Jan 31, 2022

Conversation

DavisVaughan
Copy link
Member

No description provided.

@DavisVaughan
Copy link
Member Author

The Windows test failures are related to an update in testthat that essentially means we can't write / cat() UTF8 on Windows machines, which we do here

clock/tests/testthat/test-date.R

Line 274 in b13d783

cat(date_format(x, format = format, locale = clock_locale("fr")))
. I will follow up on this in a different PR to remove this UTF8 writing

@DavisVaughan DavisVaughan merged commit cfcbeac into main Jan 31, 2022
@DavisVaughan DavisVaughan deleted the feature/rlang-1.0.0-snapshots branch January 31, 2022 17:26
@DavisVaughan DavisVaughan mentioned this pull request Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DavisVaughan