Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent line coverage #129

Closed
jimhester opened this issue Nov 17, 2015 · 2 comments
Closed

Inconsistent line coverage #129

jimhester opened this issue Nov 17, 2015 · 2 comments
Labels
bug an unexpected problem or unintended behavior
Milestone
Jan. 4

Comments

@jimhester
Copy link
Member

Between as.data.frame() and shine().

Probably the result of coverage of } lines and the like.
@jimhester jimhester added the bug an unexpected problem or unintended behavior label Jan 4, 2016
@jimhester jimhester added this to the Jan. 4 milestone Jan 4, 2016
@jimhester
Copy link
Member Author

This is due to expressions which span multiple lines (Often If/else expressions). Only the first line is counted by tally_coverage.

@jimhester
Copy link
Member Author

It was also due to not removing blank or commented lines from the counting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
Jan. 4
Development

No branches or pull requests
1 participant
@jimhester