Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate robustness of parse data generation of switch statements #325

Closed
jimhester opened this issue Aug 16, 2018 · 2 comments
Closed

Investigate robustness of parse data generation of switch statements #325

jimhester opened this issue Aug 16, 2018 · 2 comments

Comments

@jimhester
Copy link
Member

rlang passes ... to switch() (https://github.com/r-lib/rlang/blob/4d064384f42f4767979a093b6381fccbaad59a97/R/types.R#L450-L452) which results in invalid statements as covr wraps the ... in a trace block.
@hadley
Copy link
Member

hadley commented Sep 20, 2018

I think the problem might also happen with statements like switch(foo, a = , b = 2)

@jimhester
Copy link
Member Author

jimhester commented Sep 20, 2018 •
edited
Loading

Ok, I am pretty sure I got to the bottom of both of these problems, hopefully for the last time 🤞

rlang now can be run with covr again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @jimhester