Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Coverage #42

Closed
brodieG opened this issue Aug 24, 2016 · 3 comments
Closed

Increase Coverage #42

brodieG opened this issue Aug 24, 2016 · 3 comments

Comments

@brodieG
Copy link
Contributor

brodieG commented Aug 24, 2016

I looked into increasing coverage and it seems like there is a bit of code that isn't in use, such as:

  • data_frame, which I think has been mostly superseded by the switch to matrices that I made a while back
  • the code in disposable.r, which as far as I can tell isn't currently in use?

I can submit a PR addressing those plus other low hanging fruit if you're interested. I imagine there is a reason why disposable.r is in the package though.

@gaborcsardi
Copy link
Member

@brodieG
Copy link
Contributor Author

brodieG commented Aug 24, 2016

Ah, that is the skipped test, makes sense.

@gaborcsardi
Copy link
Member

I have increased it a bit. Will do more later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants