Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document() runs test helpers #1669

Closed
nbenn opened this issue Dec 7, 2017 · 2 comments · Fixed by #1670
Closed

document() runs test helpers #1669

nbenn opened this issue Dec 7, 2017 · 2 comments · Fixed by #1670

Comments

@nbenn
Copy link
Contributor

nbenn commented Dec 7, 2017

Every time devtools::document() is run, test helpers are run as well.

I put together a small package to illustrate the issue, located at nbenn/roxythat. This was the best kind of reproducible example I could come up with. Sorry for the hassle.

This might not be a bug. However I have a situation at hand where I only want the helper files to be run before tests. If this is not how test helpers are supposed to be used, I can figure something else out.
@nbenn
Copy link
Contributor Author

nbenn commented Dec 7, 2017

The fix is actually very easy: load_all has a helpers argument which can be set to FALSE.

@nbenn nbenn mentioned this issue Dec 7, 2017
Merged
@lock
Copy link

lock bot commented Sep 17, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No longer run test helpers in document() nbenn/devtools
1 participant
@nbenn