Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more contextual knowledge re: oob auth #102

Open
jennybc opened this issue Aug 12, 2019 · 1 comment

Comments

@jennybc
Copy link
Member

commented Aug 12, 2019

I could make the default logic for oob auth a bit more humane.

For example, we could determine that we are on RStudio Server and use oob auth, w/o having to receive explicit instructions via the option or arg.

How to tell?

rstudioapi::versionInfo()$mode
[1] "server"

Also, since I'm here, let me record other ways I know of learning more about context: The env var R_CONFIG_ACTIVE is "shiny" on shinyapps.io and "rstudio_cloud" on RStudio Cloud.

When you're in RStudio, you can call RStudio.Version(). But that's a function attached by RStudio itself and would presumably require weird gymnastics in a CRAN package.

RStudio v1.3 will set RSTUDIO_PROGRAM_MODE.

RSTUDIO_HTTP_REFERER is set in RStudio Servier but not in Desktop.

@jennybc jennybc added the feature label Aug 12, 2019

@jennybc

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Maybe gargle should consider the option httr_oob_default? If someone has bothered to set that, it seems a better fallback than FALSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.