Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export httr2:::url_modify() #464

Open
burgerga opened this issue Mar 27, 2024 · 1 comment
Open

Export httr2:::url_modify() #464

burgerga opened this issue Mar 27, 2024 · 1 comment
Labels
feature a feature request or enhancement url 👑

Comments

@burgerga
Copy link
Contributor

TLDR: httr::modify_url() is exported, but httr2:::url_modify() not; please export this useful function


I'm wrapping an API and upon successful POST the API unfortunately only returns a document ID and not the full URL, so to print the full URL I have to construct it by appending this document ID to the base URL. So I'm looking for a function like httr2::req_url_path() that works on a URL instead of a request. Previously, I used httr::modify_url() but the httr2 version httr2:::url_modify() is not exported, would it be possible to export this function in httr2 as well?

@hadley hadley added feature a feature request or enhancement url 👑 labels Apr 1, 2024
@hadley
Copy link
Member

hadley commented Apr 1, 2024

Yeah, that seems reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement url 👑
Projects
None yet
Development

No branches or pull requests

2 participants