Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak run_now() behavior to discourage running forever #18

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Oct 11, 2017

Repro (warning, running this on master branch will hang your R session):

local({
  run <- function() {
    later::later(run, 0.001)
    Sys.sleep(0.001)
  }
  later::later(run, 0)
  later::run_now()
})

@wch
Copy link
Member

wch commented Oct 11, 2017

LGTM

@jcheng5 jcheng5 merged commit 6f80496 into master Oct 11, 2017
@jcheng5 jcheng5 deleted the joe/bugfix/run-now-and-forever branch October 11, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants