Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate clock_gettime on macOS < 10.12 too #21

Merged
merged 1 commit into from
Jan 20, 2018

Conversation

mingwandroid
Copy link
Contributor

The Anaconda Distribution targets macOS 10.9 and above, and clock_gettime was first added to macOS at 10.12, so I needed to use the emulation function when __APPLE__ is defined but CLOCK_MONOTONIC is not.

mingwandroid added a commit to AnacondaRecipes/aggregateR that referenced this pull request Nov 8, 2017
Needs a patch because macOS 10.9 (any < 10.12) does not provide
clock_gettime() so instead use the already provided emulation.

Submitted upstream at: r-lib/later#21
@jennybc jennybc mentioned this pull request Dec 13, 2017
@jcheng5
Copy link
Member

jcheng5 commented Dec 13, 2017

@mingwandroid, thanks for the contribution and sorry for the delay! Can you please sign a CLA for this patch? If you email that to me at joe@rstudio.com I'll get this merged right away.

Thanks again!

@jcheng5
Copy link
Member

jcheng5 commented Jan 20, 2018

Because this is such a trivial merge I'm going to take it without a CLA.

@jcheng5 jcheng5 merged commit d97c5eb into r-lib:master Jan 20, 2018
@mingwandroid
Copy link
Contributor Author

Sorry I missed the CLA request. I'll make sure to sign it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants