Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_preamble in library_call_linter() to skip setup code #2170

Merged
merged 8 commits into from Sep 15, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2161

@MichaelChirico MichaelChirico marked this pull request as ready for review September 15, 2023 04:33
@AshesITR
Copy link
Collaborator

❤️ our test suite.

Code LGTM, just add the configurable tag.

AshesITR
AshesITR previously approved these changes Sep 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2170 (5e08415) into main (4c88419) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5e08415 differs from pull request most recent head ee062ce. Consider uploading reports for the commit ee062ce to get more accurate results

@@           Coverage Diff           @@
##             main    #2170   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         112      112           
  Lines        5124     5129    +5     
=======================================
+ Hits         5106     5111    +5     
  Misses         18       18           
Files Changed Coverage Δ
R/library_call_linter.R 100.00% <100.00%> (ø)

@MichaelChirico MichaelChirico merged commit f770c19 into main Sep 15, 2023
20 checks passed
@MichaelChirico MichaelChirico deleted the lc-preamble branch September 15, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

library_call_linter() should relax for Rmd files
3 participants