Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum R version to >=4.0 #2569

Open
MichaelChirico opened this issue May 4, 2024 · 5 comments
Open

Bump minimum R version to >=4.0 #2569

MichaelChirico opened this issue May 4, 2024 · 5 comments
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Milestone

Comments

@MichaelChirico
Copy link
Collaborator

Tidyversion R version support say we are now up to R>=4.0.0:

https://www.tidyverse.org/blog/2019/04/r-version-support/

There are of course some nice features in 4.0.0 we can start using, so it will be nice to take advantage of that.

OTOH, the current CRAN version only depends on R 3.5.0, so I would not make 2 version jumps in the same release. Let's release 3.2.0 with R>=3.6.0, then bump to 4.0.0 afterwards.

@MichaelChirico MichaelChirico added this to the 3.3.0 milestone May 4, 2024
@MichaelChirico MichaelChirico added the internals Issues related to inner workings of lintr, i.e., not user-visible label May 4, 2024
@AshesITR
Copy link
Collaborator

AshesITR commented May 5, 2024

Why not bump to 4.0.0 immediately?

@MichaelChirico
Copy link
Collaborator Author

I think some caution is warranted.

  1. No tidyverse packages have actually updated to R>=4.0.0 yet
  2. We don't have any releases with R>=3.6.0 requirement yet

I don't see any particular reason to rush.

@AshesITR
Copy link
Collaborator

AshesITR commented May 7, 2024

I would only bump the R version dependency if an old version actually breaks, so if we don't use any 3.6 only features, I wouldn't lock 3.5 out of lintr updates.

@IndrajeetPatil
Copy link
Collaborator

Strongly disagree. I don't want us to make empty promises to users.

Neither CRAN nor our CI builds or tests the package on R < 3.6. Unless we add this as a manual step to carry out before submitting the package to CRAN, there is no point in continuing to support older versions.

Without testing anything, we might as well support R > 2.0 to not lock anyone out. And, yes, I am being hyperbolic just to emphasize my argument 😉

@AshesITR
Copy link
Collaborator

AshesITR commented May 7, 2024

Fair point, that would prevent issues like tidyverse/purrr#1045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues related to inner workings of lintr, i.e., not user-visible
Projects
None yet
Development

No branches or pull requests

3 participants