"((" is a left paren space violation?

[peterhurford]

Currently this is a violation of the spaces_left_parentheses_linter:

if ((var == "") | (other_var == "")) {

I think (( should be legal. Is there a reason it isn't?

If this is a mistake, the solution would be to amend https://github.com/jimhester/lintr/blob/master/R/spaces_left_parentheses_linter.R#L27 to include (, right?

[wlandau]

Such a hilarious runaround:

lint("generate.R")

## generate.R:289:10: style: Place a space before left parenthesis, except in a function call.
##   while ((out <- stri_rand_strings(1, n)) %in% exclude){
##          ^

After adding a space:

lint("generate.R")

## generate.R:289:10: style: Do not place spaces around code in parentheses or square brackets.
##   while ( (out <- stri_rand_strings(1, n)) %in% exclude){
##         ^

Patching my use case with # nolint for now.

[peterhurford]

@wlandau I've run into that exact issue several times, leading me just not to do left parentheses linting.

[shimash63174]

@peterhurford I run into the same issue, Have you added not_exception <- !(before_operator %in% c("!", ":", "(")) Can't it be solve in the package?

[martin-mfg]

The reason for lintr not liking (( most probably is section 2.2 of the tidyverse style guide, which states

Place a space before (, except when it’s part of a function call.

The runaround pointed out by @wlandau is also caused by the style guide, because it is inconsistent on whether to put a space in between (( or not.

Regarding these two problems in the tidyverse style guide, I already opened an issue on the style guide's GitHub page: tidyverse/style#66.

[kenahoo]

The tidyverse style guide has been updated with a fix:

tidyverse/style@bde1f15

Can this ticket be reopened so lintr can match the style guide? There is currently no solution for code like this:

list((1:2)^3, 4)  # "Place a space before ("
list( (1:2)^3, 4)  # "Do not place spaces around code in parentheses"