Cannot suppress warnings or messages from is_online()

[ramiromagno]

hi @gaborcsardi,

It seems it is not possible to suppress either warnings or messages from is_online(), perhaps because they are neither. Still, it would be nice to be able to quiet is_online()...

> suppressMessages(pingr::is_online())
ping: google-public-dns-a.google.com: Temporary failure in name resolution
ping: b.resolvers.Level3.net: Temporary failure in name resolution
connect: Network is unreachable
connect: Network is unreachable
[1] FALSE
> suppressWarnings(pingr::is_online())
ping: google-public-dns-a.google.com: Temporary failure in name resolution
ping: b.resolvers.Level3.net: Temporary failure in name resolution
connect: Network is unreachable
connect: Network is unreachable
[1] FALSE

I believe this results from using the system() function:

pingr/R/ping-package.r

Line 65 in 6da0940

output <- suppressWarnings(system(os$cmd, intern = ! verbose))

Could you not change that system call to:

output <- suppressWarnings(
                   system(os$cmd, intern = ! verbose,
                               ignore.stdout = TRUE, ignore.stderr = TRUE)
) 

[gaborcsardi]

After switching to processx (#8), no messages are shown.