Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have vignettes not be deleted if "BuildVignettes: no" in DESCRIPTION #75

Closed
schloerke opened this issue Jun 19, 2019 · 6 comments
Closed

Comments

@schloerke
Copy link

While the 95% case is to build vignettes every time from source, I'd like to be able to not have to manually set vignettes = FALSE in pkgbuild::build if in the DESCRIPTION file states BuildVignettes: no.

This would be very handy.

@schloerke
Copy link
Author

@alandipert for shinyloadtest

@jimhester
Copy link
Member

jimhester commented Jun 19, 2019

Ok, did you try it? pkgbuild is just delegating to R CMD build, so this should already work and does seem to in a simple test package.

@schloerke
Copy link
Author

Yes. I'm trying on repo rstudio/sortable@pkgdown

If I call devtools::check(), it still asks if it can delete ./inst/doc, which I don't want it to do.
If I respond, "No", the build stops.

Calling devtools::check(vignettes = FALSE) gives me the desired behavior of not asking about deleting ./inst/doc and not building the vignettes.

@jimhester
Copy link
Member

deleting inst/doc is different than building the vignettes...

@schloerke schloerke changed the title Have vignettes not be built if "BuildVignettes: no" in DESCRIPTION Have vignettes not be deleted if "BuildVignettes: no" in DESCRIPTION Jun 19, 2019
@gaborcsardi
Copy link
Member

I think it would be great to document the newly suggested vignette workflow, and also how people show go about not rebuilding the vignettes all the time.

@jimhester
Copy link
Member

You can now use clean_doc = FALSE to avoid cleaning the inst/doc folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants