Redirect stderr to stdout #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make them correctly interleaved. This is both for build() and pkgbuild_process.
gaborcsardi
force-pushed
the
fix/stderr-to-stdout
branch
from
35d71ed
to
b4c1b2b
Compare
|
We should probably have a news entry for this, otherwise looks good |
jimhester
approved these changes
Jul 8, 2019
|
Thanks! I added the NEWS entry, so I'll merge this, once the CIs are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make them correctly interleaved. This is both
for build() and pkgbuild_process.
Otherwise it is pretty hard to show meaningful output on error, especially for the background process. But the output of
build()can also be out-of-order without this.