Remove directories after dir(). #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dir() includes directories (despite include.dirs=FALSE, directories still get included when using a non-recursive listing, which is the default). So need to filter out directories (otherwise digest() throws an error when passing a directory to it).
|
Hmmm, the build failed because the |
| @@ -20,6 +20,7 @@ package_rd <- function(package) { | |||
| package <- as.sd_package(package) | |||
|
|
|||
| rd <- dir(file.path(package$path, "man"), full.names = TRUE) | |||
| rd <- rd[!(rd %in% list.dirs(file.path(package$path, "man"), recursive=FALSE))] | |||
There was a problem hiding this comment.
How about rd <- rd[!dir.exists(rd)] ?
There was a problem hiding this comment.
Oh, didn't even know this function! Much easier that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying out
build_site()on a package which has aman/figuresdirectory. I get the error:Error: The specified pathname is not a file: [...]/man/figurestraceback()shows that this happens due todigest(). Inrd.r, I seepackage_rd(), which usesrd <- dir(file.path(package$path, "man"), full.names = TRUE)to get all files in the directory, but this also includes directories themselves (despite
include.dirs=FALSE, directories still get included when using a non-recursive listing, which is the default).So the directories need to be filtered out.