Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cph" role on front page #1012

Closed
noamross opened this issue May 9, 2019 · 13 comments
Closed

"cph" role on front page #1012

noamross opened this issue May 9, 2019 · 13 comments
Labels
feature a feature request or enhancement home 🏠 wip work in progress

Comments

@noamross
Copy link
Contributor

noamross commented May 9, 2019

For some of my packages the cph role is my organization, but they aren't fnd as projects are grant-funded. I'd like the cph author role to appear on the front page. I believe the roles appearing on the front page are currently hard-coded as aut, cre, and fnd. It would be great if this could be configured somehow, such as a flag in the for the author in the authors: YAML field of front_page: TRUE.

@jayhesselberth
Copy link
Collaborator

Can you point to an example DESCRIPTION?

@noamross
Copy link
Contributor Author

@jayhesselberth
Copy link
Collaborator

The tidyr page has a similar setup with RStudio as the cph.

https://tidyr.tidyverse.org/

We could simply add cph to the list of included roles; I can't think of any negative impact on sites:

main <- pkg %>%
pkg_authors(c("aut", "cre", "fnd")) %>%
purrr::map(author_list, author_info)

@noamross
Copy link
Contributor Author

That would work for me!

@jayhesselberth
Copy link
Collaborator

@hadley OK to add cph to the roles included for home page display?

@hadley
Copy link
Member

hadley commented May 11, 2019

I think copyright holder is too weak a role to merit inclusion on every page. For example, R-core ends up being a copyright holder in many packages because we often copy R code from newer versions to backport features to older versions. Or take shiny: it has 20 copyright holders because of the included source.

@noamross if you're including your organisation because they pay you, "fnd" seems most appropriate to me. That's how I flag RStudio as my employer.

@noamross
Copy link
Contributor Author

Well, "cph" and "fnd" are distinct roles from my perspective when you have a group doing the work with sponsorship from another organization, as is often the case with my grant-funded NGO. I can work around this, but I think the better solution would be something that lets the authors override defaults on which authors appear up front.

@hadley
Copy link
Member

hadley commented May 15, 2019

Are there any other marc roles that would work for your situation? What about "Host institution [his]" (An organization hosting the event, exhibit, conference, etc., which gave rise to a resource, but having little or no responsibility for the content of the resource)? Or "Sponsor [spn]"
(A person, family, or organization sponsoring some aspect of a resource, e.g., funding research, sponsoring an event)

@noamross
Copy link
Contributor Author

Yes, it would make sense to make my NGO c('fnd', 'cph'), if we refer to our grantors as c('spn'). Would that preclude CRAN submission as spn is not in utils:::MARC_relator_db_codes_used_with_R? Or can I override the DESCRIPTION roles in _pkgdown.yml?

@hadley
Copy link
Member

hadley commented May 15, 2019

You can also try what I did to get fnd added to the list — submit to CRAN with it in and plead your case.

@noamross
Copy link
Contributor Author

Would you accept a PR to allow for overriding the defaults in the authors: section in _pkgdown.yml?

@hadley
Copy link
Member

hadley commented May 15, 2019

Yeah, as long as it doesn't create too much additional complexity.

@hadley hadley added feature a feature request or enhancement home 🏠 wip work in progress labels May 17, 2019
@hadley
Copy link
Member

hadley commented Mar 11, 2020

Closing because we're unlikely to work on this, but we'd still welcome a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement home 🏠 wip work in progress
Projects
None yet
Development

No branches or pull requests

3 participants