Make pkgdown add class=col-md-9 in articles

[mrcaseb]

There is this line in the content-article.html template that should be able to add the col-md-9 class to main but I am not able to actually toggle it.

pkgdown/inst/BS5/templates/content-article.html

Line 6 in ae7363f

<main id="main" $if(toc)$class="col-md-9"$endif$>

I can't find any BS5 pkgdown site that uses that class for the main content in articles.

Sorry, it's hard to provide a reprex but it seems like toc: true in the article meta data doesn't have any effect.

[mrcaseb]

In other words:

This test

pkgdown/tests/testthat/test-build-articles.R

Lines 132 to 134 in ae7363f

	# We don't have a main with .col-md-9 if TOC isn't present
	xpath_contents <- ".//main[contains(@class, 'col-md-9')]"
	expect_equal(xpath_length(toc_false_html, xpath_contents), 0)

passes, even if we do

toc: true 

here

pkgdown/tests/testthat/assets/articles/vignettes/toc-false.Rmd

Line 3 in ae7363f

toc: false

[maelle]

Related (sort of) https://twitter.com/jimhester_/status/1488953531642040327

I wonder whether the problem comes from using Pandoc vs Mustache templating. #2048 (pkgdown does not use rmarkdown's toc at all).

[hadley]

@mrcaseb can you show what the problem is?

[mrcaseb]

@mrcaseb can you show what the problem is?

It started in this thread with the desire to make the main content of pkgdown sites wider on bigger screens. https://twitter.com/jimhester_/status/1488953531642040327?s=20&t=gsW4dxCbUHnRUkqDwspOTA

I've added this css to one of my pkgdown sites
https://github.com/nflverse/nflplotR/blob/e169b89fe3d3645111d78cf734cd0759be2493dd/pkgdown/extra.css#L5-L15

It works fine for the homepage,

or for the changelog

But it fails for an article. The toc is at the end of the page on that article site.

[hadley]

Thanks for that summary. Can you please now connect it to why col-md-9 would help?

[mrcaseb]

Thanks for that summary. Can you please now connect it to why col-md-9 would help?

I think I am not good enough in html or css to explain this actually. I tried to understand the actual problem, compared the article page with the other pages and added col-md-9 manually to the html (because that is the main difference between the article page and e.g. the changelog page). And it worked. See

[mrcaseb]

The article pages on my websites are fixed, thanks @hadley!