Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param seed to build_articles() #2354

Merged
merged 11 commits into from Mar 12, 2024
Merged

Add param seed to build_articles() #2354

merged 11 commits into from Mar 12, 2024

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Oct 18, 2023 •
edited

Adds a param seed to build_articles() (default 1014L) that allows reproducible pseudo-random number generation, which helps reduce noise in final HTML output.

Or should we default to seed = NULL aka the old (unreproducible) behaviour?

salim-b and others added 5 commits October 19, 2023 00:02
@salim-b
Add param seed to build_articles()
7d0b1f3 
Adds a param `seed` to `build_artiles()` that allows reproducible RNG, which can reduce noise in final HTML output.
@salim-b
Tweak doc
2c2cdbd
@salim-b
Use explicit int seed
09d0e77
@salim-b
Add NEWS bullet
b4d2455
@hadley
Merge commit 'f9803a0cad885873649a5790d2167ddabdbf3da2'
2ae31c2 
#Conflicts:
#	NEWS.md
#	man/build_site.Rd
hadley
hadley reviewed Mar 11, 2024
View reviewed changes
R/build-articles.R Outdated Show resolved Hide resolved
hadley
hadley reviewed Mar 11, 2024
View reviewed changes
R/rmarkdown.R Show resolved Hide resolved
hadley
hadley reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to make the output reproducible by default.

@hadley hadley merged commit 3c4d8f1 into r-lib:main Mar 12, 2024
13 checks passed
@hadley
Copy link
Member

hadley commented Mar 12, 2024

Thank you!

@salim-b salim-b deleted the article-seed branch March 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salim-b @hadley