Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"back of the house" code leaking into index.html #929

Closed
jennybc opened this issue Dec 5, 2018 · 3 comments
Closed

"back of the house" code leaking into index.html #929

jennybc opened this issue Dec 5, 2018 · 3 comments
Labels
bug an unexpected problem or unintended behavior home 🏠

Comments

@jennybc
Copy link
Member

jennybc commented Dec 5, 2018 •
edited
Loading

I just rebuilt the reprex site:

https://reprex.tidyverse.org

Look at the very top for some code re: header-includes. Here's a screenshot:

screen shot 2018-12-05 at 3 06 29 pm

This was introduced in my recent upgrade of tidytemplate & pkgodown + re-render:

https://github.com/tidyverse/reprex/blame/00f52f28d497177e4c97ff585c0a4106380403af/docs/index.html#L102-L108
@hadley
Copy link
Member

hadley commented Dec 5, 2018

This suggests that the template isn't being processed by pandoc. Does reprex have a .md or .Rmd?

@hadley hadley added bug an unexpected problem or unintended behavior home 🏠 labels Dec 5, 2018
@hadley hadley added this to the pkgdown 1.2.1 milestone Dec 5, 2018
@jennybc
Copy link
Member Author

jennybc commented Dec 5, 2018

reprex has a README.md.

@hadley
Copy link
Member

hadley commented Dec 6, 2018

I also see this in httr — I think the common cause is README.md

@hadley hadley closed this as completed in d689abf Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior home 🏠
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @jennybc