Add pretty_num for linear quantities #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minimal documentation
improve lisibility fix doc typo
extand the prefixes to latest 1991 list
remove 'missing description' warning on documentation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
===========================================
+ Coverage 65.26% 76.25% +10.99%
===========================================
Files 4 5 +1
Lines 95 139 +44
===========================================
+ Hits 62 106 +44
Misses 33 33
Continue to review full report at Codecov.
|
|
hello @gaborcsardi, is there something I should change on that P.R. ? |
|
@cregouby I am sorry for the delay, I'll try to look at this this weekend. 🤞 |
We can't use non-ascii characters unconditionally, unfortunately.
Need to update nrow if we rule out some prefixes.
We need a tolerance here.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as a fix to #8