Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$call should be a call or NULL in error objects #360

Open
gaborcsardi opened this issue Apr 13, 2023 · 3 comments
Open

$call should be a call or NULL in error objects #360

gaborcsardi opened this issue Apr 13, 2023 · 3 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@gaborcsardi
Copy link
Member

❯ processx::run("false")
Error in `processx::run("false")`:
! System command 'false' failed
---
Exit status: 1
Stderr: <empty>
---
Type .Last.error to see the more details.

❯ .Last.error$call
[1] "processx::run(\"false\")"

So we should use another field for the call string.

@lionel-
Copy link
Member

lionel- commented Apr 13, 2023

Or maybe just zap the srcrefs if that is the problem?

@gaborcsardi
Copy link
Member Author

It is not the only problem, calls may contain large objects.

@lionel-
Copy link
Member

lionel- commented Apr 13, 2023

Supplying a string can be generally useful for non-call contexts. Should we use the field $context? We've also started namespacing fields inside $rlang for $rlang$inherit, I guess that'd be a good idea here too.

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants