Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating so install robust to empty .gitmodules file #329

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

jsilve24
Copy link
Contributor

@jsilve24 jsilve24 commented Apr 4, 2019

I ran into a small problem when trying to install a package with an empty .gitmodules file. I isolated the problem to a single line in the update_submodules function.

I have corrected the problem by just adding a condition that if the submodules file is empty, then the function should exit in exactly the same way as if the file had not been found. This makes the function robust to empty .gitmodules files.

Hope this helps.

Justin

@jimhester jimhester merged commit 310abaf into r-lib:master Apr 9, 2019
@jimhester
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants