updating so install robust to empty .gitmodules file #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a small problem when trying to install a package with an empty .gitmodules file. I isolated the problem to a single line in the update_submodules function.
I have corrected the problem by just adding a condition that if the submodules file is empty, then the function should exit in exactly the same way as if the file had not been found. This makes the function robust to empty .gitmodules files.
Hope this helps.
Justin