Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_gitlab() should pass quiet to gitlab_pat() #437

Closed
MichaelChirico opened this issue Sep 21, 2019 · 1 comment · Fixed by #438
Closed

install_gitlab() should pass quiet to gitlab_pat() #437

MichaelChirico opened this issue Sep 21, 2019 · 1 comment · Fixed by #438

Comments

@MichaelChirico
Copy link
Contributor

MichaelChirico commented Sep 21, 2019

formals(remotes::install_gitlab)[c('auth_token', 'quiet')]
# $auth_token
# gitlab_pat()

# $quiet
# [1] FALSE

formals(remotes:::gitlab_pat)
# $quiet
# [1] TRUE

Seems it would be simple & consistent to pass quiet on to gitlab_pat. Will file a PR shortly.

@jimhester
Copy link
Member

jimhester commented Sep 23, 2019

This is currently actually what we want, the install functions default to not being quiet, but we don't want to print output every time the PAT is looked up.

The quiet argument exists in gitlab_pat() and github_pat() only for debugging purposes when it is called directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants