-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When requesting HEAD, dont use --branch #612
Conversation
Catch additional uses of --branch
@jimhester hello - sorry to bug but I wanted to check back on this PR. Again, I think this bug would have been hard to encounter before; however, if one tries to checkout bioconductor packages where release = 'Dev' it will be hit. The problem (unless I'm missing something in git), is that 'HEAD' isnt a valid value for '--branch'. This PR checks for 'HEAD' and prevents adding '--branch=HEAD'. If there's another solution to this I'm happy to adjust. Thanks in advance. |
@jimhester hey - thought i'd check back on this. i've been using this branch on github actions for a couple months and this fix does work. is there a chance you'd be willing to accept the PR? |
Can you please add a bullet to NEWS? It should briefly describe the change and end with |
@jimhester done |
@jimhester just following up: anything else you need me to do here? |
@jimhester good morning - just thought i'd check back again. is there anything else you need? |
@jimhester great - thanks! |
@jimhester - this is related to #580, but I missed it before.
When the bioc development branch is specified, remotes will use 'HEAD' as the branch. This results in something like:
I think the right solution is to not include "--branch" in the git command if the requested branch is HEAD. I believe this has been a long-standing issue, that could not easily have been hit before.