Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging in Range R6 classes #379

Open
teunbrand opened this issue Feb 14, 2023 · 0 comments · May be fixed by #416
Open

Improve messaging in Range R6 classes #379

teunbrand opened this issue Feb 14, 2023 · 0 comments · May be fixed by #416

Comments

@teunbrand
Copy link
Contributor

This suggestion is lifted over from tidyverse/ggplot2#4258.

Briefly, train_discrete() and train_continuous() throw errors that can be hard to debug in some cases.
If tidyverse/ggplot2#5086 is merged, that would leave responsibility over Range classes with {scales}, so that is why I'm opening this issue here.

My proposal would be that the Range classes get an optional field with a scale name or aesthetic name that can be used for communicating more informative errors. Responsibility for providing an informative field would then bounce the ball back to ggplot2.

@teunbrand teunbrand linked a pull request Dec 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant