Support diffing session info's from GHA logs #68

jennybc · 2022-01-29T17:03:00Z

Add support to session_diff() for new and old to be URLs that link to a GitHub Actions job.

Currently session diff works best when comparing sessions for two jobs of the same "flavour", because you don't pick up differences in package source. This has nothing to do with GHA, but is something I've really noticed while working on this, because I do really want to do cross-flavour comparisons. I have another idea for that which is proposed in #69.

Here it is in action, comparing two adjacent GHA runs for readr, both on ubuntu-18.04 (release), showing that the differences in the library are magrittr and rlang.

devtools::load_all()
#> ℹ Loading sessioninfo
session_diff(
  # a successful GHA run
  "https://github.com/tidyverse/readr/runs/4971816401?check_suite_focus=true",
  # the next GHA run, which failed ... WHY?
  "https://github.com/tidyverse/readr/runs/4976911977?check_suite_focus=true",
)
#> --- ubuntu-18.04 (release) | success | job 4971816401 | run 1758177206
#> +++ ubuntu-18.04 (release) | failure | job 4976911977 | run 1760148193
#>  ─ Session info ───────────────────────────────────────────────────────────────
#>   setting  value
#>   version  R version 4.1.2 (2021-11-01)
#>   os       Ubuntu 18.04.6 LTS
#>   system   x86_64, linux-gnu
#>   ui       X11
#>   language (EN)
#>   collate  C.UTF-8
#>   ctype    C.UTF-8
#>   tz       UTC
#>   pandoc   2.14.2 @ /usr/bin/pandoc
#>  
#>  ─ Packages ───────────────────────────────────────────────────────────────────
#>   package     * version    date (UTC) lib source
#>   askpass       1.1        2019-01-13 [1] RSPM
#>   base        * 4.1.2      2022-01-04 [2] local
#>   base64enc     0.1-3      2015-07-28 [1] RSPM
#>   bit           4.0.4      2020-08-04 [1] RSPM
#>   bit64         4.0.5      2020-08-30 [1] RSPM
#>   boot          1.3-28     2021-05-03 [2] CRAN (R 4.1.2)
#>   brio          1.1.3      2021-11-30 [1] RSPM
#>   callr         3.7.0      2021-04-20 [1] RSPM
#>   class         7.3-19     2021-05-03 [2] CRAN (R 4.1.2)
#>   cli           3.1.1      2022-01-20 [1] RSPM
#>   clipr         0.7.1      2020-10-08 [1] RSPM
#>   cluster       2.1.2      2021-04-17 [2] CRAN (R 4.1.2)
#>   codetools     0.2-18     2020-11-04 [2] CRAN (R 4.1.2)
#>   commonmark    1.7        2018-12-01 [1] RSPM
#>   compiler      4.1.2      2022-01-04 [2] local
#>   covr          3.5.1      2020-09-16 [1] RSPM
#>   cpp11         0.4.2      2021-11-30 [1] RSPM
#>   crayon        1.4.2      2021-10-29 [1] RSPM
#>   curl          4.3.2      2021-06-23 [1] RSPM
#>   datasets    * 4.1.2      2022-01-04 [2] local
#>   desc          1.4.0      2021-09-28 [1] RSPM
#>   diffobj       0.3.5      2021-10-05 [1] RSPM
#>   digest        0.6.29     2021-12-01 [1] RSPM
#>   ellipsis      0.3.2      2021-04-29 [1] RSPM
#>   evaluate      0.14       2019-05-28 [1] RSPM
#>   fansi         1.0.2      2022-01-14 [1] RSPM
#>   fastmap       1.1.0      2021-01-25 [1] RSPM
#>   foreign       0.8-81     2020-12-22 [2] CRAN (R 4.1.2)
#>   glue          1.6.1      2022-01-22 [1] RSPM
#>   graphics    * 4.1.2      2022-01-04 [2] local
#>   grDevices   * 4.1.2      2022-01-04 [2] local
#>   grid          4.1.2      2022-01-04 [2] local
#>   highr         0.9        2021-04-16 [1] RSPM
#>   hms           1.1.1      2021-09-26 [1] RSPM
#>   htmltools     0.5.2      2021-08-25 [1] RSPM
#>   httr          1.4.2      2020-07-20 [1] RSPM
#>   hunspell      3.0.1      2020-12-09 [1] RSPM
#>   jquerylib     0.1.4      2021-04-26 [1] RSPM
#>   jsonlite      1.7.3      2022-01-17 [1] RSPM
#>   KernSmooth    2.23-20    2021-05-03 [2] CRAN (R 4.1.2)
#>   knitr         1.37       2021-12-16 [1] RSPM
#>   lattice       0.20-45    2021-09-22 [2] CRAN (R 4.1.2)
#>   lazyeval      0.2.2      2019-03-15 [1] RSPM
#>   lifecycle     1.0.1      2021-09-24 [1] RSPM
#> - magrittr      2.0.1      2020-11-17 [1] RSPM
#> + magrittr      2.0.2      2022-01-26 [1] RSPM
#>   MASS          7.3-54     2021-05-03 [2] CRAN (R 4.1.2)
#>   Matrix        1.3-4      2021-06-01 [2] CRAN (R 4.1.2)
#>   methods     * 4.1.2      2022-01-04 [2] local
#>   mgcv          1.8-38     2021-10-06 [2] CRAN (R 4.1.2)
#>   mime          0.12       2021-09-28 [1] RSPM
#>   nlme          3.1-153    2021-09-07 [2] CRAN (R 4.1.2)
#>   nnet          7.3-16     2021-05-03 [2] CRAN (R 4.1.2)
#>   openssl       1.4.6      2021-12-19 [1] RSPM
#>   pak           0.2.0.9000 2022-01-27 [1] local
#>   parallel      4.1.2      2022-01-04 [2] local
#>   pillar        1.6.5      2022-01-25 [1] RSPM
#>   pkgbuild      1.3.1      2021-12-20 [1] RSPM
#>   pkgconfig     2.0.3      2019-09-22 [1] RSPM
#>   pkgload       1.2.4      2021-11-30 [1] RSPM
#>   praise        1.0.0      2015-08-11 [1] RSPM
#>   prettyunits   1.1.1      2020-01-24 [1] RSPM
#>   processx      3.5.2      2021-04-30 [1] RSPM
#>   progress      1.2.2      2019-05-16 [1] RSPM
#>   ps            1.6.0      2021-02-28 [1] RSPM
#>   purrr         0.3.4      2020-04-17 [1] RSPM
#>   R6            2.5.1      2021-08-19 [1] RSPM
#>   rcmdcheck     1.4.0      2021-09-27 [1] any (@1.4.0)
#>   Rcpp          1.0.8      2022-01-13 [1] RSPM
#>   rematch2      2.1.2      2020-05-01 [1] RSPM
#>   rex           1.2.1      2021-11-26 [1] RSPM
#> - rlang         0.4.12     2021-10-18 [1] RSPM
#> + rlang         1.0.0      2022-01-26 [1] RSPM
#>   rmarkdown     2.11       2021-09-14 [1] RSPM
#>   rpart         4.1-15     2019-04-12 [2] CRAN (R 4.1.2)
#>   rprojroot     2.0.2      2020-11-15 [1] RSPM
#>   rstudioapi    0.13       2020-11-12 [1] RSPM
#>   sessioninfo   1.2.2      2021-12-06 [1] any (@1.2.2)
#>   spatial       7.3-14     2021-05-03 [2] CRAN (R 4.1.2)
#>   spelling      2.2        2020-10-18 [1] RSPM
#>   splines       4.1.2      2022-01-04 [2] local
#>   stats       * 4.1.2      2022-01-04 [2] local
#>   stats4        4.1.2      2022-01-04 [2] local
#>   stringi       1.7.6      2021-11-29 [1] RSPM
#>   stringr       1.4.0      2019-02-10 [1] RSPM
#>   survival      3.2-13     2021-08-24 [2] CRAN (R 4.1.2)
#>   sys           3.4        2020-07-23 [1] RSPM
#>   tcltk         4.1.2      2022-01-04 [2] local
#>   testthat      3.1.2      2022-01-20 [1] RSPM
#>   tibble        3.1.6      2021-11-07 [1] RSPM
#>   tidyselect    1.1.1      2021-04-30 [1] RSPM
#>   tinytex       0.36       2021-12-19 [1] RSPM
#>   tools         4.1.2      2022-01-04 [2] local
#>   tzdb          0.2.0      2021-10-27 [1] RSPM
#>   utf8          1.2.2      2021-07-24 [1] RSPM
#>   utils       * 4.1.2      2022-01-04 [2] local
#>   vctrs         0.3.8      2021-04-29 [1] RSPM
#>   vroom         1.5.7      2021-11-30 [1] RSPM
#>   waldo         0.3.1      2021-09-14 [1] RSPM
#>   withr         2.4.3      2021-11-30 [1] RSPM
#>   xfun          0.29       2021-12-14 [1] RSPM
#>   xml2          1.3.3      2021-11-30 [1] RSPM
#>   xopen         1.0.0      2018-09-17 [1] RSPM
#>   yaml          2.2.2      2022-01-25 [1] RSPM
#>  
#>   [1] /home/runner/work/_temp/Library
#>   [2] /opt/R/4.1.2/lib/R/library
#>  
#>  ──────────────────────────────────────────────────────────────────────────────

^{Created on 2022-01-29 by the reprex package (v2.0.1.9000)}

codecov-commenter · 2022-01-29T17:05:46Z

Codecov Report

Merging #68 (44a0895) into main (59e1b11) will decrease coverage by 2.90%.
The diff coverage is 31.70%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   82.59%   79.69%   -2.91%     
==========================================
  Files          13       14       +1     
  Lines         678      719      +41     
==========================================
+ Hits          560      573      +13     
- Misses        118      146      +28

Impacted Files	Coverage Δ
R/github-actions.R	`30.76% <30.76%> (ø)`
R/compare.R	`99.49% <50.00%> (-0.51%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e1b11...44a0895. Read the comment docs.

R/github-actions.R

gaborcsardi

Looks great, one more small comment.

gaborcsardi · 2022-02-01T17:44:26Z

R/github-actions.R

+  timestamped_lines <- unlist(strsplit(raw_log$message, split = "\r\n"))
+  lines <- sub("^.+Z ", "", timestamped_lines)
+  start_pos <- grep("##[group]Session info", lines, fixed = TRUE)
+  endgroups <- grep("##[endgroup]", lines, fixed = TRUE)


I think these would be more robust if we just searched for

─ Session info ──

and also the ascii variant of this. I think some other sessioninfo parsers are doing that.

Some recent action versions don't have the ##[group] prefix I think, and we might also change this.

…pace

jennybc · 2022-02-01T22:39:04Z

OK I made the requested changes.

gaborcsardi · 2022-02-02T08:38:50Z

Thanks, this is going to be great!

MVP for diffing session info's from GHA logs

99aa056

jennybc mentioned this pull request Jan 31, 2022

Use a join, instead of line diff, to compare package info #69

Merged

jennybc added 2 commits January 30, 2022 19:12

Document support for GHA log URLs

44a0895

Remove extra line

4fbd868

jennybc commented Jan 31, 2022

View reviewed changes

R/github-actions.R Outdated Show resolved Hide resolved

jennybc commented Jan 31, 2022

View reviewed changes

R/github-actions.R Show resolved Hide resolved

jennybc commented Jan 31, 2022

View reviewed changes

R/github-actions.R Outdated Show resolved Hide resolved

gaborcsardi reviewed Feb 1, 2022

View reviewed changes

jennybc added 4 commits February 1, 2022 11:55

Use stop() instead of cli::cli_abort()

35edc0a

Trim timestamp by removing everything up to and including the first s…

89092f7

…pace

Be more like find_session_info_in_html()

e2bcd4f

Add NEWS bullet

d4b97c8

jennybc changed the title ~~MVP for diffing session info's from GHA logs~~ Support diffing session info's from GHA logs Feb 1, 2022

gaborcsardi merged commit 6c683ac into main Feb 2, 2022

gaborcsardi deleted the github-actions-logs branch February 2, 2022 08:38

gaborcsardi mentioned this pull request Feb 23, 2022

parsing sessioinfo object from GH actions? #70

Closed

jennybc mentioned this pull request Mar 2, 2022

Only trim a single space when removing the timestamp #71

Closed

jennybc mentioned this pull request Mar 22, 2023

Update GHA log parsing to reflect current URL structure #85

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support diffing session info's from GHA logs #68

Support diffing session info's from GHA logs #68

jennybc commented Jan 29, 2022 •

edited

Loading

codecov-commenter commented Jan 29, 2022 •

edited

Loading

gaborcsardi left a comment

gaborcsardi Feb 1, 2022

jennybc commented Feb 1, 2022

gaborcsardi commented Feb 2, 2022

Support diffing session info's from GHA logs #68

Support diffing session info's from GHA logs #68

Conversation

jennybc commented Jan 29, 2022 • edited Loading

codecov-commenter commented Jan 29, 2022 • edited Loading

Codecov Report

gaborcsardi left a comment

Choose a reason for hiding this comment

gaborcsardi Feb 1, 2022

Choose a reason for hiding this comment

jennybc commented Feb 1, 2022

gaborcsardi commented Feb 2, 2022

jennybc commented Jan 29, 2022 •

edited

Loading

codecov-commenter commented Jan 29, 2022 •

edited

Loading