Replace purrr::when() with if() equivalents

[IndrajeetPatil]

This function will be deprecated in the next (1.0.0) {purrr} release (https://github.com/tidyverse/purrr/blob/55c9a8ab8788d878ce9e8e80b867139e46d15395/R/deprec-when.R#L57), and so we should remove its usage to prevent user-facing deprecation messages.

[github-actions]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if be75da3 is merged into main:

•   :ballot_box_with_check:cache_applying: 37.4ms -> 36.2ms [-10.18%, +3.63%]
•   :ballot_box_with_check:cache_recording: 1.14s -> 1.14s [-1.47%, +0.7%]
•   :ballot_box_with_check:without_cache: 2.98s -> 2.97s [-1.62%, +0.85%]

Further explanation regarding interpretation and methodology can be found in the documentation.

[lorenzwalthert]

Thanks. I am not sure we should port it since it requires maintenance. Can't we just use if, as the docs suggest? Also, when does this require a new release on CRAN to avoid a user facing warning?

[IndrajeetPatil]

Can't we just use if, as the docs suggest?

Done. No longer porting over the function.

Also, when does this require a new release on CRAN to avoid a user facing warning?

IIRC, {purrr} is scheduled for CRAN submission on the 15th of December.

[codecov-commenter]

Codecov Report

Merging #1066 (fd531d8) into main (be75da3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          46       46           
  Lines        2685     2685           
=======================================
  Hits         2445     2445           
  Misses        240      240           

Impacted Files	Coverage Δ
R/nest.R	100.00% <100.00%> (ø)
R/rules-tokens.R	100.00% <100.00%> (ø)
R/transform-files.R	97.41% <100.00%> (+0.01%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

This is how benchmark results would change (along with a 95% confidence interval in relative change) if be75da3 is merged into main:

•   :ballot_box_with_check:cache_applying: 24.1ms -> 24.7ms [-2.65%, +7.51%]
•   :rocket:cache_recording: 745ms -> 740ms [-1.19%, -0.25%]
•   :rocket:without_cache: 1.87s -> 1.84s [-2.04%, -0.97%]

Further explanation regarding interpretation and methodology can be found in the documentation.

[lorenzwalthert]

IIRC, {purrr} is scheduled for CRAN submission on the 15th of December.

Should we release a new version before that?

[IndrajeetPatil]

Should we release a new version before that?

Yes, I think that would be a good idea. Maybe at the end of this month?

Btw, can I upgrade myself from ctb to aut for the next release?
I don't know if you have a particular milestone in mind when this should happen.