Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix styling around {{ if comments are involved #1088

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #1070.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Merging #1088 (22119ac) into main (0b34e99) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
- Coverage   91.10%   91.04%   -0.07%     
==========================================
  Files          46       46              
  Lines        2699     2702       +3     
==========================================
+ Hits         2459     2460       +1     
- Misses        240      242       +2     
Impacted Files Coverage Δ
R/rules-line-breaks.R 100.00% <100.00%> (ø)
R/roxygen-examples-find.R 93.33% <0.00%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8d683de is merged into main:

  •   :ballot_box_with_check:cache_applying: 65.7ms -> 65.7ms [-2.58%, +2.63%]
  •   :ballot_box_with_check:cache_recording: 1.15s -> 1.13s [-2.75%, +0.46%]
  •   :ballot_box_with_check:without_cache: 2.77s -> 2.76s [-1.57%, +0.88%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8d683de is merged into main:

  •   :ballot_box_with_check:cache_applying: 54.4ms -> 54.6ms [-1.15%, +1.74%]
  •   :ballot_box_with_check:cache_recording: 957ms -> 958ms [-1.18%, +1.32%]
  •   :ballot_box_with_check:without_cache: 2.27s -> 2.28s [-1.27%, +1.64%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IndrajeetPatil IndrajeetPatil merged commit 196d31a into main Dec 28, 2022
@IndrajeetPatil IndrajeetPatil deleted the issue-1070 branch December 28, 2022 10:16
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2c1dfc9 is merged into main:

  •   :ballot_box_with_check:cache_applying: 64.9ms -> 65.2ms [-2.34%, +3.32%]
  •   :ballot_box_with_check:cache_recording: 1.16s -> 1.16s [-0.42%, +1.06%]
  •   :ballot_box_with_check:without_cache: 2.77s -> 2.77s [-0.52%, +0.66%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling resulted in code that isn't parsable.
3 participants