Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qmd as supported value to filetype parameter #1091

Merged
merged 2 commits into from Jan 17, 2023

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Jan 16, 2023

"qmd" was missing as a supported value from the filetype parameter docs.

I did not roxygenise(), yet.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6a24c73 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we missed updating this one. Glad you caught it.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1091 (8f97b81) into main (6a24c73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files          46       46           
  Lines        2711     2711           
=======================================
  Hits         2469     2469           
  Misses        242      242           
Impacted Files Coverage Δ
R/ui-styling.R 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit 8208348 into r-lib:main Jan 17, 2023
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6a24c73 is merged into main:

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants