Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check benchmarks only with rlang bump #1107

Merged
merged 1 commit into from Apr 5, 2023
Merged

Check benchmarks only with rlang bump #1107

merged 1 commit into from Apr 5, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 92b3d08 is merged into main:

  •   :ballot_box_with_check:cache_applying: 66.5ms -> 66.3ms [-1.28%, +0.6%]
  •   :ballot_box_with_check:cache_recording: 901ms -> 901ms [-0.82%, +0.7%]
  •   :ballot_box_with_check:without_cache: 2.15s -> 2.15s [-0.83%, +0.75%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert self-requested a review April 5, 2023 09:42
@lorenzwalthert lorenzwalthert merged commit db9bbed into main Apr 5, 2023
8 of 19 checks passed
@lorenzwalthert lorenzwalthert deleted the bump-rlang-stable-release branch April 5, 2023 09:42
@lorenzwalthert
Copy link
Collaborator

Not 100% sure we also use rlang 1.1.0 in the benchmarks. Let's wait and see for the logs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 92b3d08 is merged into main:

  •   :ballot_box_with_check:cache_applying: 73.7ms -> 73.4ms [-2.19%, +1.52%]
  •   :ballot_box_with_check:cache_recording: 956ms -> 959ms [-1.22%, +1.91%]
  •   :ballot_box_with_check:without_cache: 2.49s -> 2.48s [-1.4%, +0.97%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzwalthert lorenzwalthert lorenzwalthert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IndrajeetPatil @lorenzwalthert