Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRAN warning on invalid numeric version inputs #1143

Merged
merged 4 commits into from Aug 22, 2023

Conversation

lorenzwalthert
Copy link
Collaborator

This is about the "invalid non-character version specification" errors
for r-devel-linux-x86_64-debian-gcc.
R-devel has been warning about invalid (non-character) numeric version
inputs for some time now, but such warnings typically go unnoticed, so
at least for the time being, one can get errors instead of warnings by
setting R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS=true.
In your case,
assert_transformers <- function(transformers) {
version_cutoff <- 2.0
needs "2.0" ...

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #1143 (17167fd) into main (1fc5b13) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 17167fd differs from pull request most recent head 922573c. Consider uploading reports for the commit 922573c to get more accurate results

@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files          46       46           
  Lines        2650     2650           
=======================================
  Hits         2447     2447           
  Misses        203      203           
Files Changed Coverage Δ
R/set-assert-args.R 90.47% <100.00%> (ø)

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if aca7223 is merged into main:

  •   :ballot_box_with_check:cache_applying: 231ms -> 228ms [-2.79%, +0.74%]
  •   :ballot_box_with_check:cache_recording: 751ms -> 748ms [-1.07%, +0.44%]
  •   :ballot_box_with_check:without_cache: 1.4s -> 1.4s [-0.44%, +0.28%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b13 is merged into main:

  •   :ballot_box_with_check:cache_applying: 239ms -> 238ms [-1.54%, +1.29%]
  •   :ballot_box_with_check:cache_recording: 759ms -> 762ms [-0.34%, +1.11%]
  •   :ballot_box_with_check:without_cache: 1.4s -> 1.4s [-0.7%, +0.86%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b13 is merged into main:

  •   :ballot_box_with_check:cache_applying: 276ms -> 275ms [-1.73%, +1.52%]
  •   :ballot_box_with_check:cache_recording: 827ms -> 826ms [-0.91%, +0.49%]
  •   :ballot_box_with_check:without_cache: 1.5s -> 1.5s [-0.92%, +0.48%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Aug 22, 2023

on win devel, the message is not even shown:

  • using log directory 'd:/RCompile/CRANguest/R-devel/styler.Rcheck'
  • using R Under development (unstable) (2023-08-20 r84995 ucrt)
  • using platform: x86_64-w64-mingw32
  • R was compiled by
    gcc.exe (GCC) 12.2.0
    GNU Fortran (GCC) 12.2.0
  • running under: Windows Server 2022 x64 (build 20348)
  • using session charset: UTF-8
  • checking for file 'styler/DESCRIPTION' ... OK
  • checking extension type ... Package
  • this is package 'styler' version '1.10.1'
  • package encoding: UTF-8
  • checking CRAN incoming feasibility ... [25s] WARNING
    Maintainer: 'Lorenz Walthert lorenz.walthert@icloud.com'

Insufficient package version (submitted: 1.10.1, existing: 1.10.1)

  • checking package namespace information ... OK
  • checking package dependencies ... OK
  • checking if this is a source package ... OK
  • checking if there is a namespace ... OK
  • checking for hidden files and directories ... OK
  • checking for portable file names ... OK
  • checking whether package 'styler' can be installed ... OK
  • checking installed package size ... OK
  • checking package directory ... OK
  • checking for future file timestamps ... OK
  • checking 'build' directory ... OK
  • checking DESCRIPTION meta-information ... OK
  • checking top-level files ... OK
  • checking for left-over files ... OK
  • checking index information ... OK
  • checking package subdirectories ... OK
  • checking R files for non-ASCII characters ... OK
  • checking R files for syntax errors ... OK
  • checking whether the package can be loaded ... OK
  • checking whether the package can be loaded with stated dependencies ... OK
  • checking whether the package can be unloaded cleanly ... OK
  • checking whether the namespace can be loaded with stated dependencies ... OK
  • checking whether the namespace can be unloaded cleanly ... OK
  • checking loading without being on the library search path ... OK
  • checking whether startup messages can be suppressed ... OK
  • checking use of S3 registration ... OK
  • checking dependencies in R code ... OK
  • checking S3 generic/method consistency ... OK
  • checking replacement functions ... OK
  • checking foreign function calls ... OK
  • checking R code for possible problems ... [13s] OK
  • checking Rd files ... OK
  • checking Rd metadata ... OK
  • checking Rd line widths ... OK
  • checking Rd cross-references ... OK
  • checking for missing documentation entries ... OK
  • checking for code/documentation mismatches ... OK
  • checking Rd \usage sections ... NOTE
    Documented arguments not in \usage in documentation object 'is_insufficiently_parsed_string':
    'text'

Documented arguments not in \usage in documentation object 'set_line_break_if_call_is_multi_line':
'except_token_after' 'except_text_before' 'force_text_before'

Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.

  • checking Rd contents ... OK
  • checking for unstated dependencies in examples ... OK
  • checking installed files from 'inst/doc' ... OK
  • checking files in 'vignettes' ... OK
  • checking examples ... OK
  • checking for unstated dependencies in 'tests' ... OK
  • checking tests ... [56s] OK
    Running 'testthat.R' [56s]
  • checking for unstated dependencies in vignettes ... OK
  • checking package vignettes in 'inst/doc' ... OK
  • checking re-building of vignette outputs ... OK
  • checking PDF version of manual ... [21s] OK
  • checking HTML version of manual ... [29s] OK
  • DONE
    Status: 1 WARNING, 1 NOTE

@lorenzwalthert
Copy link
Collaborator Author

Quite strange that the GitHub Action itself fails at 0s. Opened an issue: r-lib/actions#756

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b13 is merged into main:

  •   :ballot_box_with_check:cache_applying: 202ms -> 203ms [-1.62%, +2.89%]
  •   :ballot_box_with_check:cache_recording: 657ms -> 659ms [-0.47%, +1.1%]
  •   :ballot_box_with_check:without_cache: 1.22s -> 1.23s [-0.28%, +0.65%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b13 is merged into main:

  •   :ballot_box_with_check:cache_applying: 231ms -> 232ms [-0.42%, +1.89%]
  •   :ballot_box_with_check:cache_recording: 682ms -> 681ms [-2.99%, +2.9%]
  •   :ballot_box_with_check:without_cache: 1.29s -> 1.3s [-0.48%, +1.54%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit ca400ad into main Aug 22, 2023
17 of 18 checks passed
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1fc5b13 is merged into main:

  •   :ballot_box_with_check:cache_applying: 211ms -> 209ms [-1.92%, +0.75%]
  •   :ballot_box_with_check:cache_recording: 711ms -> 714ms [-0.23%, +1.08%]
  •   :ballot_box_with_check:without_cache: 1.34s -> 1.34s [-0.42%, +0.56%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert deleted the fix-cran-warning branch August 23, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants