Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete URL check workflow #1160

Merged
merged 2 commits into from Dec 3, 2023
Merged

Delete URL check workflow #1160

merged 2 commits into from Dec 3, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

I am not sure what's special about {styler} that this workflow fails. My hunch is that including a lot of GitHub links corresponding to all contributors somehow makes GitHub API calls exceed beyond the limit for this workflow in this repo.

At any rate, this is not so important to merit further investigation. We just need to run URL check before CRAN submission and we should be fine.

@@ -161,7 +161,7 @@ A big shout out to anyone who contributed to this release:
This release was requested by CRAN to resolve an R CMD Check note (#1044).
A big hand to everyone who made this release possible:

[@DaveJarvis](https://github.com/DaveJarvis),
Dave Jarvis,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This user no longer exists and so this URL has certainly rotten.

@IndrajeetPatil
Copy link
Collaborator Author

The precommit workflow is going to fail until #1158 is merged, and so need to wait for that PR to be merged.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12f7eb6) 92.35% compared to head (5b8e8f0) 92.35%.
Report is 5 commits behind head on main.

❗ Current head 5b8e8f0 differs from pull request most recent head ae7b351. Consider uploading reports for the commit ae7b351 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          46       46           
  Lines        2654     2654           
=======================================
  Hits         2451     2451           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenzwalthert
Copy link
Collaborator

@lorenzwalthert
Copy link
Collaborator

But I am fine deleting the workflow and do the check upon submission.

@lorenzwalthert lorenzwalthert merged commit f4f61d9 into main Dec 3, 2023
15 checks passed
@lorenzwalthert lorenzwalthert deleted the delete-url-check-workflow branch December 3, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants