Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning in test-io #1169

Merged
merged 2 commits into from Dec 8, 2023
Merged

Suppress warning in test-io #1169

merged 2 commits into from Dec 8, 2023

Conversation

IndrajeetPatil
Copy link
Collaborator

Closes #1161

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10efce2) 92.16% compared to head (4447865) 92.16%.

❗ Current head 4447865 differs from pull request most recent head aac55d7. Consider uploading reports for the commit aac55d7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          46       46           
  Lines        2655     2655           
=======================================
  Hits         2447     2447           
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil
Copy link
Collaborator Author

@lorenzwalthert Can we deal with this flaky test? It is making it more likely that we miss out an actual failing test.

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('tests-cache-require-serial.R:28:3'): top-level test: Caches top-level expressions efficiently on style_text() ──
full_cached_benchmark["elapsed"] * 30 is not strictly less than benchmark["elapsed"]. Difference: 0.01

@lorenzwalthert
Copy link
Collaborator

Yeah let's lift the hurdle for failing, e.g. x20 instead of x 30?

@lorenzwalthert
Copy link
Collaborator

Sounds good, thanks for implementing. If you want, you can also add the fix for the offending unrelated test to this PR.

@IndrajeetPatil IndrajeetPatil merged commit ebe4997 into main Dec 8, 2023
15 checks passed
@IndrajeetPatil IndrajeetPatil deleted the fix-test-io-warning branch December 8, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dealing with warnings in tests on Windows
3 participants